[HUDI-8787] Improve compaction performance by reducing unnecessary disk access #12531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HoodieMergeHandle::writeIncomingRecords
will always read all the log records from disk even thought these log records we have previously confirmed that we do not need to insert.So we should push down this predicate to
ExternalSpillableMap::iterator
to avoid unnecessary disk access.Change Logs
ExternalSpillableMap
Describe context and summary for this change. Highlight if any code was copied.
Impact
none
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
none
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist