Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8787] Improve compaction performance by reducing unnecessary disk access #12531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheR1sing3un
Copy link
Member

@TheR1sing3un TheR1sing3un commented Dec 20, 2024

HoodieMergeHandle::writeIncomingRecords will always read all the log records from disk even thought these log records we have previously confirmed that we do not need to insert.
image
So we should push down this predicate to ExternalSpillableMap::iterator to avoid unnecessary disk access.

Change Logs

  1. improve compaction performance by avoid unnecessary disk visiting
  2. support push down predicate to ExternalSpillableMap

Describe context and summary for this change. Highlight if any code was copied.

Impact

none
Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

none
If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

1. improve compaction performance by avoid unnecessary disk visiting
2. support push down predicate to `ExternalSpillableMap`

Signed-off-by: TheR1sing3un <[email protected]>
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M PR with lines of changes in (100, 300]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants