Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8767] Add bundle validation for release artifacts in Maven central #12488

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

codope
Copy link
Member

@codope codope commented Dec 13, 2024

Change Logs

Currently, we have bundle validation for artifacts staged in nexus repo. To ensure the necessary bundles are released to maven central, we should validate the bundles after they appear in maven central.

  • Add bundle validation for release artifacts in maven central
  • Update release guide to run this validation after artifacts appear in maven central
  • Update how to run this validation in bundle validation README

Impact

Ensuring release artifacts in Maven central are valid.

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Dec 13, 2024
Comment on lines 81 to 83
validate-release-maven-artifacts:
runs-on: ubuntu-latest
if: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had created separate PR #12486 with this action turned on and Maven artifact validation succeeded - https://github.com/apache/hudi/actions/runs/12312424031/

Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codope could you also check bundle validation failures in the non-release validation jobs?

@yihua yihua force-pushed the HUDI-8767-bundle-validation-maven branch from 59c4429 to a30d790 Compare February 1, 2025 06:55
@hudi-bot
Copy link

hudi-bot commented Feb 1, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua
Copy link
Contributor

yihua commented Feb 1, 2025

The maven artifact validation workflow is validated in https://github.com/apache/hudi/pull/12757/checks
Screenshot 2025-01-31 at 23 39 04

@yihua yihua merged commit 229dee7 into apache:master Feb 1, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M PR with lines of changes in (100, 300]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants