-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-7262][0.x] Validate checksum only if it exists #10764
Conversation
68b32f9
to
082f24d
Compare
@beyond1920 @yihua Hi, this fix is important for reading 0.10.x or earlier version of hudi table using 0.x-branch. I pick it from 1.x branch, PTAL~ |
Oh, the conflict is wired. @yihua Or could you help pick this commit directly to 0.x branch? Thanks~ |
Hi @stream2000 thanks for the contribution. I've updated |
082f24d
to
271da11
Compare
Sure! Already rebased fixed the conflicts. |
Thanks! Here's the PR to enable CI on branch-0.x and PRs targeting it: #10765 |
0e6369f
to
d07274d
Compare
@stream2000 now CI works. I have to cherry-pick my changes on GH workflows on |
d07274d
to
3ea894e
Compare
3ea894e
to
4a28095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you also add the link to the original PR targeting master?
Sure. Added the link in the Pr description. |
Change Logs
Only validate the checksum if it exists.
Otherwise, some operations would throw exceptions. For example:
If a HUDI table was created with 0.10 Hudi version and read by 0.14.0, an IllegalArgumentExeption would be thrown out because checksum property doesn't exist in hoodie.properties.
Fail to upgrade a table created with 0.10 HUDI version using 0.14 version, an IllegalArgumentExeption would be thrown out because checksum property doesn't exist in hoodie.properties.
See more information in #10404.
Origin PR on master by @beyond1920 : #10417
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist