-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-29516 Fix NPE in StatsUtils.updateStats when column statistics a… #6382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhluck
wants to merge
2
commits into
apache:master
Choose a base branch
from
shubhluck:HIVE-29516
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+182
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
ql/src/test/queries/clientpositive/semijoin_stats_missing_colstats.q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| -- HIVE-29516: Verify that query compilation succeeds when column statistics | ||
| -- are missing during semijoin optimization in removeSemijoinOptimizationByBenefit. | ||
|
|
||
| set hive.tez.dynamic.partition.pruning=true; | ||
| set hive.tez.dynamic.semijoin.reduction=true; | ||
| set hive.tez.bigtable.minsize.semijoin.reduction=1; | ||
| set hive.tez.min.bloom.filter.entries=1; | ||
| set hive.tez.bloom.filter.factor=1.0f; | ||
| set hive.auto.convert.join=false; | ||
|
|
||
| create table t1_nocolstats (id int, val string); | ||
| create table t2_nocolstats (id int, val string); | ||
|
|
||
| alter table t1_nocolstats update statistics set('numRows'='100000000', 'rawDataSize'='2000000000'); | ||
| alter table t2_nocolstats update statistics set('numRows'='1000', 'rawDataSize'='20000'); | ||
|
|
||
| explain | ||
| select t1.id, t1.val, t2.val | ||
| from t1_nocolstats t1 join t2_nocolstats t2 on t1.id = t2.id; |
161 changes: 161 additions & 0 deletions
161
ql/src/test/results/clientpositive/llap/semijoin_stats_missing_colstats.q.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| PREHOOK: query: create table t1_nocolstats (id int, val string) | ||
| PREHOOK: type: CREATETABLE | ||
| PREHOOK: Output: database:default | ||
| PREHOOK: Output: default@t1_nocolstats | ||
| POSTHOOK: query: create table t1_nocolstats (id int, val string) | ||
| POSTHOOK: type: CREATETABLE | ||
| POSTHOOK: Output: database:default | ||
| POSTHOOK: Output: default@t1_nocolstats | ||
| PREHOOK: query: create table t2_nocolstats (id int, val string) | ||
| PREHOOK: type: CREATETABLE | ||
| PREHOOK: Output: database:default | ||
| PREHOOK: Output: default@t2_nocolstats | ||
| POSTHOOK: query: create table t2_nocolstats (id int, val string) | ||
| POSTHOOK: type: CREATETABLE | ||
| POSTHOOK: Output: database:default | ||
| POSTHOOK: Output: default@t2_nocolstats | ||
| PREHOOK: query: alter table t1_nocolstats update statistics set('numRows'='100000000', 'rawDataSize'='2000000000') | ||
| PREHOOK: type: ALTERTABLE_UPDATETABLESTATS | ||
| PREHOOK: Input: default@t1_nocolstats | ||
| PREHOOK: Output: default@t1_nocolstats | ||
| POSTHOOK: query: alter table t1_nocolstats update statistics set('numRows'='100000000', 'rawDataSize'='2000000000') | ||
| POSTHOOK: type: ALTERTABLE_UPDATETABLESTATS | ||
| POSTHOOK: Input: default@t1_nocolstats | ||
| POSTHOOK: Output: default@t1_nocolstats | ||
| PREHOOK: query: alter table t2_nocolstats update statistics set('numRows'='1000', 'rawDataSize'='20000') | ||
| PREHOOK: type: ALTERTABLE_UPDATETABLESTATS | ||
| PREHOOK: Input: default@t2_nocolstats | ||
| PREHOOK: Output: default@t2_nocolstats | ||
| POSTHOOK: query: alter table t2_nocolstats update statistics set('numRows'='1000', 'rawDataSize'='20000') | ||
| POSTHOOK: type: ALTERTABLE_UPDATETABLESTATS | ||
| POSTHOOK: Input: default@t2_nocolstats | ||
| POSTHOOK: Output: default@t2_nocolstats | ||
| PREHOOK: query: explain | ||
| select t1.id, t1.val, t2.val | ||
| from t1_nocolstats t1 join t2_nocolstats t2 on t1.id = t2.id | ||
| PREHOOK: type: QUERY | ||
| PREHOOK: Input: default@t1_nocolstats | ||
| PREHOOK: Input: default@t2_nocolstats | ||
| #### A masked pattern was here #### | ||
| POSTHOOK: query: explain | ||
| select t1.id, t1.val, t2.val | ||
| from t1_nocolstats t1 join t2_nocolstats t2 on t1.id = t2.id | ||
| POSTHOOK: type: QUERY | ||
| POSTHOOK: Input: default@t1_nocolstats | ||
| POSTHOOK: Input: default@t2_nocolstats | ||
| #### A masked pattern was here #### | ||
| STAGE DEPENDENCIES: | ||
| Stage-1 is a root stage | ||
| Stage-0 depends on stages: Stage-1 | ||
|
|
||
| STAGE PLANS: | ||
| Stage: Stage-1 | ||
| Tez | ||
| #### A masked pattern was here #### | ||
| Edges: | ||
| Map 1 <- Reducer 4 (BROADCAST_EDGE) | ||
| Reducer 2 <- Map 1 (SIMPLE_EDGE), Map 3 (SIMPLE_EDGE) | ||
| Reducer 4 <- Map 3 (CUSTOM_SIMPLE_EDGE) | ||
| #### A masked pattern was here #### | ||
| Vertices: | ||
| Map 1 | ||
| Map Operator Tree: | ||
| TableScan | ||
| alias: t1 | ||
| filterExpr: (id is not null and id BETWEEN DynamicValue(RS_7_t2_id_min) AND DynamicValue(RS_7_t2_id_max) and in_bloom_filter(id, DynamicValue(RS_7_t2_id_bloom_filter))) (type: boolean) | ||
| Statistics: Num rows: 100000000 Data size: 17860000188 Basic stats: COMPLETE Column stats: NONE | ||
| Filter Operator | ||
| predicate: (id is not null and id BETWEEN DynamicValue(RS_7_t2_id_min) AND DynamicValue(RS_7_t2_id_max) and in_bloom_filter(id, DynamicValue(RS_7_t2_id_bloom_filter))) (type: boolean) | ||
| Statistics: Num rows: 95000000 Data size: 16967000178 Basic stats: COMPLETE Column stats: NONE | ||
| Select Operator | ||
| expressions: id (type: int), val (type: string) | ||
| outputColumnNames: _col0, _col1 | ||
| Statistics: Num rows: 95000000 Data size: 16967000178 Basic stats: COMPLETE Column stats: NONE | ||
| Reduce Output Operator | ||
| key expressions: _col0 (type: int) | ||
| null sort order: z | ||
| sort order: + | ||
| Map-reduce partition columns: _col0 (type: int) | ||
| Statistics: Num rows: 95000000 Data size: 16967000178 Basic stats: COMPLETE Column stats: NONE | ||
| value expressions: _col1 (type: string) | ||
| Execution mode: vectorized, llap | ||
| LLAP IO: all inputs | ||
| Map 3 | ||
| Map Operator Tree: | ||
| TableScan | ||
| alias: t2 | ||
| filterExpr: id is not null (type: boolean) | ||
| Statistics: Num rows: 1000 Data size: 178788 Basic stats: COMPLETE Column stats: NONE | ||
| Filter Operator | ||
| predicate: id is not null (type: boolean) | ||
| Statistics: Num rows: 950 Data size: 169848 Basic stats: COMPLETE Column stats: NONE | ||
| Select Operator | ||
| expressions: id (type: int), val (type: string) | ||
| outputColumnNames: _col0, _col1 | ||
| Statistics: Num rows: 950 Data size: 169848 Basic stats: COMPLETE Column stats: NONE | ||
| Reduce Output Operator | ||
| key expressions: _col0 (type: int) | ||
| null sort order: z | ||
| sort order: + | ||
| Map-reduce partition columns: _col0 (type: int) | ||
| Statistics: Num rows: 950 Data size: 169848 Basic stats: COMPLETE Column stats: NONE | ||
| value expressions: _col1 (type: string) | ||
| Select Operator | ||
| expressions: _col0 (type: int) | ||
| outputColumnNames: _col0 | ||
| Statistics: Num rows: 950 Data size: 169848 Basic stats: COMPLETE Column stats: NONE | ||
| Group By Operator | ||
| aggregations: min(_col0), max(_col0), bloom_filter(_col0, expectedEntries=950) | ||
| minReductionHashAggr: 0.99 | ||
| mode: hash | ||
| outputColumnNames: _col0, _col1, _col2 | ||
| Statistics: Num rows: 1 Data size: 340 Basic stats: COMPLETE Column stats: NONE | ||
| Reduce Output Operator | ||
| null sort order: | ||
| sort order: | ||
| Statistics: Num rows: 1 Data size: 340 Basic stats: COMPLETE Column stats: NONE | ||
| value expressions: _col0 (type: int), _col1 (type: int), _col2 (type: binary) | ||
| Execution mode: vectorized, llap | ||
| LLAP IO: all inputs | ||
| Reducer 2 | ||
| Execution mode: llap | ||
| Reduce Operator Tree: | ||
| Merge Join Operator | ||
| condition map: | ||
| Inner Join 0 to 1 | ||
| keys: | ||
| 0 _col0 (type: int) | ||
| 1 _col0 (type: int) | ||
| outputColumnNames: _col0, _col1, _col3 | ||
| Statistics: Num rows: 104500002 Data size: 18663700600 Basic stats: COMPLETE Column stats: NONE | ||
| Select Operator | ||
| expressions: _col0 (type: int), _col1 (type: string), _col3 (type: string) | ||
| outputColumnNames: _col0, _col1, _col2 | ||
| Statistics: Num rows: 104500002 Data size: 18663700600 Basic stats: COMPLETE Column stats: NONE | ||
| File Output Operator | ||
| compressed: false | ||
| Statistics: Num rows: 104500002 Data size: 18663700600 Basic stats: COMPLETE Column stats: NONE | ||
| table: | ||
| input format: org.apache.hadoop.mapred.SequenceFileInputFormat | ||
| output format: org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat | ||
| serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe | ||
| Reducer 4 | ||
| Execution mode: vectorized, llap | ||
| Reduce Operator Tree: | ||
| Group By Operator | ||
| aggregations: min(VALUE._col0), max(VALUE._col1), bloom_filter(VALUE._col2, 1, expectedEntries=950) | ||
| mode: final | ||
| outputColumnNames: _col0, _col1, _col2 | ||
| Statistics: Num rows: 1 Data size: 340 Basic stats: COMPLETE Column stats: NONE | ||
| Reduce Output Operator | ||
| null sort order: | ||
| sort order: | ||
| Statistics: Num rows: 1 Data size: 340 Basic stats: COMPLETE Column stats: NONE | ||
| value expressions: _col0 (type: int), _col1 (type: int), _col2 (type: binary) | ||
|
|
||
| Stage: Stage-0 | ||
| Fetch Operator | ||
| limit: -1 | ||
| Processor Tree: | ||
| ListSink | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the core fix that addresses the issue described in the Jira case. To avoid unnecessary side effects let's keep the scope of the PR restricted to this and revert all the other changes. This will also help in advancing and merging this PR faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zabetak, for your patience in reviewing this. Based on your feedback, I’ve kept the changes minimal and updated the test accordingly.
The test fix sets hive.auto.convert.join=false, which forces reduce-side joins and results in semi-join branches. The EXPLAIN output now includes in_bloom_filter and bloom_filter operators, confirming that removeSemijoinOptimizationByBenefit is triggered with non-zero SemiJoinBranchInfo