Skip to content

Conversation

zabetak
Copy link
Member

@zabetak zabetak commented Sep 23, 2025

What changes were proposed in this pull request?

  1. Add dedicated driver/config (TestTPCDSCteCliDriver/TPCDSCteCliConfig) for running CTE suggestion tests with TPC-DS stats.
  2. Drop set hive.optimize.cte.suggester.class from cbo_query*.q files and update golden files for TestTezTPCDS30TBPerfCliDriver .

Why are the changes needed?

  1. Decouple experimental CTE features from main plan regression suite.
  2. Allow fine-tuning of CTE properties for increasing code coverage in this area.

Check HIVE-29224 for more details.

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -Dtest=TestTPCDSCteCliDriver
mvn test -Dtest=TestTezTPCDS30TBPerfCliDriver

Decouple experimental CTE features from main plan regression suite.
Allow fine-tuning of CTE properties for increasing code coverage in this area.
Copy link
Contributor

@okumin okumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

sonarqubecloud bot commented Oct 2, 2025

@zabetak zabetak merged commit 008f4d1 into apache:master Oct 3, 2025
4 checks passed
@zabetak
Copy link
Member Author

zabetak commented Oct 3, 2025

Many thanks for the review @okumin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants