HIVE-26493: Hive throws error when querying a view that was created successfully #6093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasakrisz
reviewed
Sep 23, 2025
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewAnalyzer.java
Outdated
Show resolved
Hide resolved
|
kasakrisz
reviewed
Sep 30, 2025
|
|
||
| String expandedText = ctx.getTokenRewriteStream().toString(select.getTokenStartIndex(), select.getTokenStopIndex()); | ||
|
|
||
| if (imposedSchema != null) { |
There was a problem hiding this comment.
Storing the extra brackets in the expanded text is not necessary even when column names are not specified so trimming them could be moved before this if statement.
kasakrisz
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-26493: Hive throws error when querying a view that was created successfully
What changes were proposed in this pull request?
While creating view, if column names are specified and the view definition is enclosed within the brackets then view creation is ok but while selecting the data from view, as here user provided column names the view definition is becoming like
select col1 as c1 from ((select col1 from tab)) v0, here view definition is already enclosed within brackets and we also adding an extra brackets again, which is causing compile failure.So as a part of fix, if view definition is already enclosed within brackets then not adding the brackets again.
Why are the changes needed?
Without fix, the data from view cannot be selected.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Using q tests
mvn -Dtest=TestMiniLlapLocalCliDriver -Dqfile=viewdef_within_brackets.q -pl itests/qtest -Pitests