Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28541: Incorrectly treating materialized CTE as Table when privi… #5471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shuaiqig
Copy link

What changes were proposed in this pull request?

https://issues.apache.org/jira/browse/HIVE-28541

  • check isMaterializedTable() before adding elements into Collection<ReadEntity>
  • add materialized CTE's real ReadEntity into parent's inputs

Why are the changes needed?

it is a bug, which caused an exception when I used hive.optimize.cte.materialize.threshold

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

It is hard to test with simple units. I tested and deployed it in my production environment.

Copy link

sonarcloud bot commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants