HIVE-28343 Iceberg: Major QB Compaction support filter in compaction … #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zratkai
force-pushed
the
HIVE-28343-optimize-where
branch
from
1cd83f8
to
3332d30
Compare
difin
reviewed
Sep 18, 2024
parser/src/test/org/apache/hadoop/hive/ql/parse/TestParseOptimizeTable.java
Outdated
Show resolved
Hide resolved
|
Looks good to me, pending tests and minor ask related to the new unit test. |
zratkai
commented
Sep 18, 2024
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
zratkai
force-pushed
the
HIVE-28343-optimize-where
branch
from
3332d30
to
2be2b9c
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
aturoczy
approved these changes
Sep 19, 2024
zratkai
force-pushed
the
HIVE-28343-optimize-where
branch
from
2be2b9c
to
d6dd6e8
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
deniskuzZ
reviewed
Sep 23, 2024
...r/src/test/queries/positive/iceberg_optimize_table_partition_evolution_w_dyn_spec_w_filter.q
Outdated
Show resolved
Hide resolved
deniskuzZ
requested changes
Sep 24, 2024
There was a problem hiding this comment.
You haven't implemented any new compaction functionality, but added just a parser sugar. There is no need to test the whole Hive for such a minor change.
The new test is a complete copy-paste of the existing test without sugar, so it's just a waste of Jenkins resources. qtests are expensive and are overkill for such minor changes.
You need to test that optimize command is being correctly rewritten to alter and that is it.
zratkai
force-pushed
the
HIVE-28343-optimize-where
branch
from
d6dd6e8
to
c20a141
Compare
|
@deniskuzZ I deleted the qtest. |
…request in OPTIMIZE TABLE command Change-Id: I6e3c09f67423cf559f315d6f448877c967da7479
zratkai
force-pushed
the
HIVE-28343-optimize-where
branch
from
c20a141
to
f05b2ce
Compare
asf-ci-hive
added
tests passed
tests pending
tests unstable
and removed
tests pending
tests passed
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-28343 Iceberg: Major QB Compaction support filter in compaction request in OPTIMIZE TABLE command
Change-Id: I6e3c09f67423cf559f315d6f448877c967da7479
What changes were proposed in this pull request?
With this PR user can execute optimize table command with condition.
Why are the changes needed?
To execute optimize table with condition.
Does this PR introduce any user-facing change?
Yes, user. can use optimize table with condition.
Is the change a dependency upgrade?
No.
How was this patch tested?
Unit test, qtest.