-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28417: Bump Log4j2 to 2.23.1 to facilitate compilation of GraalVM Native Image #5375
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @pgaref I don't understand why the bot didn't update the github tag after I put the PR back for review. Do you know how to make the bot update the github tag again?
- update 1st: To be honest, I can't understand the error log of https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5375/5/tests .
Unexpected exception java.lang.RuntimeException: Process docker failed to run in 30 seconds
at org.apache.hadoop.hive.ql.externalDB.AbstractExternalDB.runCmd(AbstractExternalDB.java:91)
at org.apache.hadoop.hive.ql.externalDB.AbstractExternalDB.runCmdAndPrintStreams(AbstractExternalDB.java:106)
- update 2nd: I took a moment to get to know the Jenkins UI... Looks like it should work, right?
- update 3rd: Wait Fix handling of
onMatch
andonMismatch
attributes in the properties configuration format logging-log4j2#2791 . - update 4th: All done.
3c8dd38
to
dddaef4
Compare
dddaef4
to
bced6fd
Compare
bced6fd
to
74d4f7f
Compare
74d4f7f
to
b29964e
Compare
06aace5
to
9bf1112
Compare
9bf1112
to
ec689f5
Compare
ec689f5
to
dad81a5
Compare
Quality Gate passedIssues Measures |
@@ -49,9 +44,6 @@ appender.DRFA.policies.time.modulate = true | |||
appender.DRFA.strategy.type = DefaultRolloverStrategy | |||
appender.DRFA.strategy.max = 30 | |||
|
|||
# list of all loggers | |||
loggers = HadoopIPC, HadoopSecurity, Hdfs, HdfsServer, HadoopMetrics2, Mortbay, Yarn, YarnServer, Tez, HadoopConf, Zookeeper, ServerCnxn, NIOServerCnxn, ClientCnxn, ClientCnxnSocket, ClientCnxnSocketNIO, DataNucleus, Datastore, JPOX, Operator, Serde2Lazy, ObjectStore, CalcitePlanner, AmazonAws, ApacheHttp, Thrift, Jetty, BlockStateChange, swo, CBORuleLogger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linghengqian, any reason for removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Refer to Fix handling of
onMatch
andonMismatch
attributes in the properties configuration format logging-log4j2#2791 (comment) and https://logging.apache.org/log4j/2.x/manual/configuration.html#Properties mentioned in my PR description. According to the log4j2 committer, defining alogger
no longer requires listing aloggers
root node, and thisloggers
root node will be removed in log4j2 version 3.0. -
Or we can keep the root
loggers
node until log4j2 removes it in version 3.0.
Prior to version 2.6, the properties configuration requires that you list the identifiers of the appenders, filters and loggers, in a comma separated list in properties with those names. Each of those components will then be expected to be defined in sets of properties that begin with component.<.identifier>.. The identifier does not have to match the name of the component being defined but must uniquely identify all the attributes and subcomponents that are part of the component. If the list of identifiers is not present the identifier must not contain a '.'. Each individual component MUST have a "type" attribute specified that identifies the component's Plugin type.
As of version 2.6, this list of identifiers is no longer required as names are inferred upon first usage, however if you wish to use more complex identifies you must still use the list. If the list is present it will be used.
Had 1 question, added it as comment. Otherwise java and pom changes LGTM (+1 non-binding). |
What changes were proposed in this pull request?
Why are the changes needed?
apache/logging-log4j2:2.23.1
can be used under the GraalVM Native Image compiled by GraalVM CE For JDK 22.0.2.org.apache.logging.slf4j.Log4jMarker
has changed.onMatch
andonMismatch
attributes in the properties configuration format logging-log4j2#2791 and When bump from 2.23.0 to 2.23.1, thestatus
of the.properties
configuration file no longer works logging-log4j2#2794 . The Log4j configuration file used by Hive contains deprecated properties .Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
Below is the output of
mvn dependency:tree > ./dependency-tree.txt
.dependency-tree.txt
How was this patch tested?