HIVE-28358: Enable JDBC getClob retrieval from String columns #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes an implementation for the getClob(int) and getClob(String) methods of HiveBaseResultSet.
Why are the changes needed?
please see HIVE-28358.
Does this PR introduce any user-facing change?
Yes. The current getClob() methods of HiveBaseResultSet just throw an exception. The proposed change returns a SerialClob already initialized with a char array obtained from the corresponding getString() methods.
Is the change a dependency upgrade?
No
How was this patch tested?
Testing was done inside the "poorly designed application". Other additional tests were not deemed useful since the functionality is not present in the master release.