HIVE-28314: Support literals as filter expression with non-boolean re… #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
zabetak
reviewed
Jun 18, 2024
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
iceberg/iceberg-handler/src/test/queries/positive/delete_iceberg_mixed.q
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
zabetak
approved these changes
Jun 24, 2024
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
|
mr3project
pushed a commit
to mr3project/hive-mr3
that referenced
this pull request
Aug 21, 2024
…Das reviewed by Stamatis Zampetakis) Close apache/hive#5291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…turn type
What changes were proposed in this pull request?
Cast literals of filter expression with boolean for queries like
select * from t1 where 'foo', so that they can be compiled with CBO.Why are the changes needed?
Refer to https://issues.apache.org/jira/browse/HIVE-27831
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -pl itests/qtest -Pitests -Dtest=TestMiniLlapLocalCliDriver -Dtest.output.overwrite=true -Dqfile="annotate_stats_filter.q"mvn test -pl itests/qtest-iceberg -Piceberg -Pitests -Dtest=TestIcebergLlapLocalCliDriver -Dqfile=delete_iceberg_mixed.q