HIVE-28292: Optimize SHOW TABLES|VIEWS statements #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
wecharyu
commented
Jun 1, 2024
| tables = client.getTables("d*", "*"); | ||
| Assert.assertEquals("All tables size", 7, tables.size()); | ||
| tables = client.getTables("def*", "*"); | ||
| Assert.assertEquals("All tables size", 5, tables.size()); |
There was a problem hiding this comment.
Remove these tests, discussed in #4326 (comment).
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
@dengzhhu653 @deniskuzZ @zhangbutao Could you please help review this patch? |
deniskuzZ
reviewed
Jun 4, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesFormatter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 4, 2024
...re/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 4, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesOperation.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 4, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesOperation.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 4, 2024
ql/src/test/results/clientpositive/llap/authorization_privilege_objects.q.out
Show resolved
Hide resolved
|
deniskuzZ
reviewed
Sep 14, 2024
deniskuzZ
reviewed
Sep 14, 2024
deniskuzZ
reviewed
Sep 14, 2024
deniskuzZ
reviewed
Sep 14, 2024
deniskuzZ
reviewed
Sep 14, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesFormatter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Sep 14, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesFormatter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Sep 14, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesFormatter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Sep 14, 2024
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesOperation.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make some improvements in
SHOW TABLESstatement:UNIQUETABLE(TBL_NAME, DB_ID)toUNIQUETABLE (DB_ID, TBL_NAME)and drop indexTBLS_N49(DB_ID)Why are the changes needed?
Improve the performance of
SHOW TABLES|VIEWSstatements.Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Passing existing tests and do benchmark tests.
java -jar hmsbench.jar -H localhost --savedata /tmp/benchdata --sanitize -N 100 -N 10000 -o bench_results.csv -C -d testbench_http --params=100 -M 'listTables.*'