-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28262:Single column use MultiDelimitSerDe parse column error #5252
HIVE-28262:Single column use MultiDelimitSerDe parse column error #5252
Conversation
581203e
to
8ed9c19
Compare
8ed9c19
to
3e3c458
Compare
3e3c458
to
87df75f
Compare
|
87df75f
to
3cae7af
Compare
Ok, I will check it |
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
Outdated
Show resolved
Hide resolved
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
Outdated
Show resolved
Hide resolved
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
Outdated
Show resolved
Hide resolved
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java
Outdated
Show resolved
Hide resolved
LGTM. Pending some nit comments. :) |
3cae7af
to
2725680
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
What changes were proposed in this pull request?
modify LazyStruct#findIndexes function and LazyStruct#parseMultiDelimit function, change fields.length Conditional judgment:
I add an test for this fix:
Why are the changes needed?
If a table only have one column field with multidelimit,query this column data is error data.
When I use this data to do other operation(e.g cast use UDFToLong function),get result is NULL.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
test class: serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyStruct.java
test function: org.apache.hadoop.hive.serde2.lazy.TestLazyStruct#testParseMultiDelimit
test command: mvn test -Dtest=TestLazyStruct --pl serde