HIVE-27995: Fix inconsistent behavior of LOAD DATA command for partitoned and non-partitioned tables

[shivjha30]

What changes were proposed in this pull request?

Earlier, the code flows for partitioned and non-partitioned tables were different. The partitioned tables skipped constraints checks before submitting the job for execution. This Pull request ensures that both, the partitioned and non-partitioned tables go through the constraints validations in applyConstraintsAndGetFiles function.

Why are the changes needed?

For partitioned tables, while executing LOAD DATA/ LOAD DATA LOCAL commands, the check for file existence is not executed on HiveServer2, and this in turn throws java.io.FileNotFoundException during Runtime once the job is launched.
This PR prevents such cases at compile time.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

The test cases already exist. The error messages prompted back to the user are now consistent if the file is not found at HiveServer2

Load Data Error (Non Partitioned Tables)

File Not Found Exception (Partitioned Tables)

Fixed: For partitioned tables

[ayushtkn]

you need to add a test, there are NegativeCLIDrivers which can be used.

There are bunch of return statements below the current line & the place where it is there right now, So, if that returned was called earlier, this applyConstraintsAndGetFiles(fromURI, ts.tableHandle); must not have been called, but now you would be calling that, right?. So, that is some additional cost just for error message?

[shivjha30]

@ayushtkn Thanks for the review, i have added the test case as mentioned above.please review once

[shivjha30]

There is a test failure in Jenkins, i ran the test in in local and that test is passing which can be viewed in the below screenshot:

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the [email protected] list if the patch is in need of reviews.

[chinnaraolalam]

Overall changes looks good to me, But locally when i run newly added test case it falling

[ERROR] TestNegativeLlapCliDriver.testCliDriver:59 Client Execution succeeded but contained differences (error code = 1) after executing load_data_partition.q 15,21c15 < FAILED: SemanticException Line 2:17 Invalid path ''hdfs://### HDFS PATH ###'': No files matching path hdfs://### HDFS PATH ### < FAILED: AssertionError java.lang.AssertionError: Client Execution succeeded but contained differences (error code = 1) after executing load_data_partition.q < 15c15 < < FAILED: SemanticException Line 2:17 Invalid path ''hdfs://### HDFS PATH ###'': No files matching path hdfs://### HDFS PATH ###

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[chinnaraolalam]

Here there is no error, I think it is failing before the expected scenario.