Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
InvisibleProgrammer committed Jan 30, 2024
1 parent cadcdd3 commit e7720d5
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,9 @@ public void testCleaningOfAbortedDirectoriesBelowBase() throws Exception {

Mockito.verifyNoInteractions(mockedFSRemover);
Mockito.verify(mockedTaskHandler, Mockito.times(1)).getTasks();
String compactionQueuePresence = "SELECT COUNT(*) FROM \"COMPACTION_QUEUE\" " +
" WHERE \"CQ_DATABASE\" = '" + dbName+ "' AND \"CQ_TABLE\" = '" + tableName + "' AND \"CQ_PARTITION\" IS NULL";
Assert.assertEquals(1, TestTxnDbUtil.countQueryAgent(conf, compactionQueuePresence));

directories = getDirectories(conf, t, null);
// Both base and delta files are present since the cleaner skips them as there is a newer write.
Expand Down Expand Up @@ -327,6 +330,7 @@ public void testAbortedCleaningWithThreeTxnsWithDiffWriteIds() throws Exception
addDeltaFile(t, null, writeId1, writeId1, 2);
addDeltaFile(t, null, writeId2, writeId2, 2);

ms.abortTxns(Collections.singletonList(openTxnId2));
ms.commitTxn(openTxnId3);

HiveConf.setIntVar(conf, HiveConf.ConfVars.HIVE_COMPACTOR_ABORTEDTXN_THRESHOLD, 0);
Expand Down

0 comments on commit e7720d5

Please sign in to comment.