Cast ALL non-boolean filter conditions to boolean

apache · Jul 10, 2024 · 49f6e8c · 49f6e8c
1 parent 6610f7c
commit 49f6e8c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java b/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
@@ -3200,9 +3200,8 @@ private RelNode genFilterRelNode(ASTNode filterNode, RelNode srcRel,
 
     private RelNode genFilterRelNode(RexNode filterExpression, RelNode srcRel,
         ImmutableMap<String, Integer> outerNameToPosMap, RowResolver outerRR) {
-      if (RexUtil.isLiteral(filterExpression, false)
-          && filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
-        // Cast filterExpression of queries like select * from t1 where 'foo'
+      if (filterExpression.getType().getSqlTypeName() != SqlTypeName.BOOLEAN) {
+        // Cast filterExpression with BOOLEAN if it is not BOOLEAN
         RelDataType booleanType = srcRel.getCluster().getTypeFactory().createSqlType(SqlTypeName.BOOLEAN);
         filterExpression = srcRel.getCluster().getRexBuilder()
             .makeCast(booleanType, filterExpression);