Skip to content

Conversation

@LZD-PratyushBhatt
Copy link

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
This PR closes #3033 Support Manual Auto Exit for Maintenance Mode

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

  1. Introduce a timeout parameter for manual maintenance mode entry.
  2. When entering maintenance mode manually, users can specify a timeout.
  3. If the cluster is still in maintenance mode after the timeout, Helix will automatically exit maintenance mode.
  4. If no timeout is specified, auto-exit does not occur.
  5. For controller-triggered maintenance mode (due to offline nodes), the existing behavior remains: the cluster exits maintenance mode only when the offline node count drops below the threshold.

Tests

  • The following tests are written for this issue:
    To be written

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@LZD-PratyushBhatt LZD-PratyushBhatt marked this pull request as draft May 5, 2025 17:52
@LZD-PratyushBhatt LZD-PratyushBhatt force-pushed the lzd_pratyush/emm_with_timeout branch from 1aad420 to ca8ad9c Compare May 5, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Manual Auto Exit for Maintenance Mode

1 participant