Skip to content

HBASE-30017 Links lead to localhost in generated PDF docs #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PDavid merged 1 commit into from
Mar 26, 2026
+12 −0
Merged

HBASE-30017 Links lead to localhost in generated PDF docs #7976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions hbase-website/app/pages/_docs/docs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,18 @@ const renderer = toClientRenderer(
}
}

// Bare fragment links must use a plain <a> — React Router's Link resolves
// to="#fragment" relative to the current pathname, producing e.g.
// /docs/single-page#transactions, which Chrome embeds as an absolute
// localhost URL in PDFs instead of an internal GoTo annotation.
if (transformedHref?.startsWith("#")) {
return (
<a href={transformedHref} {...rest}>
{children}
</a>
);
}

// Use default Link component for all links (external links are handled by Link component)
return (
<Link to={transformedHref ?? "#"} {...rest}>
Expand Down