-
Notifications
You must be signed in to change notification settings - Fork 3.3k
HBASE-29293 Upgrade to latest opentelemetry libraries #6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, now we can move to a non-alpha semconv although it might introduce some incompatibilities in naming conventions. I am not targeting non-alpha with this change, we can do it as another commit, so that we can backport this one to all active branches first. WDYT, should I introduce that change along with this PR itself? Ref:
CC: @ndimiduk |
...shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…kages into shaded jars and assembly
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assemblies need to have opentelemetry-semconv in client-facing-thirdparty.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @NihalJain !
Great catch @stoty , sorry just missed it. Update PR with the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
...-shaded-with-hadoop-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
🎊 +1 overall
This message was automatically generated. |
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
💔 -1 overall
This message was automatically generated. |
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly. * Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes` * Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv` Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82a2ddf)
…e#6969), PRISMA-2023-0067
We are using pretty old opentelemetry libraries which were released almost 3 years ago. Maybe it's good for us to move to latest ones. With this PR we are:
io.opentelemetry:opentelemetry-semconv
to relocated groupidio.opentelemetry.semconv:opentelemetry-semconv
and change imports accordingly.HBaseSemanticAttributes
io.opentelemetry.semconv:opentelemetry-semconv
fromio.opentelemetry:opentelemetry-semconv