Skip to content

HBASE-29293 Upgrade to latest opentelemetry libraries #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025

Conversation

NihalJain
Copy link
Contributor

@NihalJain NihalJain commented May 8, 2025

We are using pretty old opentelemetry libraries which were released almost 3 years ago. Maybe it's good for us to move to latest ones. With this PR we are:

  • Bumping to latest versions
  • Move from io.opentelemetry:opentelemetry-semconv to relocated groupid io.opentelemetry.semconv:opentelemetry-semconv and change imports accordingly.
  • Refactoring to keep all semantic attributes inside HBaseSemanticAttributes
  • Add appropriate excludes and includes for renamed groupid io.opentelemetry.semconv:opentelemetry-semconv from io.opentelemetry:opentelemetry-semconv

@NihalJain
Copy link
Contributor Author

NihalJain commented May 8, 2025

Also, now we can move to a non-alpha semconv although it might introduce some incompatibilities in naming conventions. I am not targeting non-alpha with this change, we can do it as another commit, so that we can backport this one to all active branches first.

WDYT, should I introduce that change along with this PR itself?

Ref:

CC: @ndimiduk

@NihalJain NihalJain requested a review from ndimiduk May 8, 2025 09:52
@NihalJain NihalJain changed the title HBASE-29293 Upgrade to latest opentelemetry packages HBASE-29293 Upgrade to latest opentelemetry libraries May 8, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assemblies need to have opentelemetry-semconv in client-facing-thirdparty.

@Apache-HBase

This comment has been minimized.

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @NihalJain !

@NihalJain
Copy link
Contributor Author

The assemblies need to have opentelemetry-semconv in client-facing-thirdparty.

Great catch @stoty , sorry just missed it. Update PR with the fix!

@NihalJain NihalJain requested a review from stoty May 19, 2025 16:30
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 56s master passed
+1 💚 compile 9m 34s master passed
+1 💚 checkstyle 1m 17s master passed
+1 💚 spotbugs 10m 48s master passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 3s the patch passed
+1 💚 compile 7m 58s the patch passed
+1 💚 javac 7m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 34s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 xmllint 0m 1s No new issues.
+1 💚 spotbugs 13m 0s the patch passed
+1 💚 hadoopcheck 12m 1s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 1m 40s The patch does not generate ASF License warnings.
76m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6969/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6969
Optional Tests dupname asflicense javac codespell detsecrets xmllint spotless spotbugs checkstyle compile hadoopcheck hbaseanti shellcheck shelldocs
uname Linux b93f091523f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0e0a480
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 190 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server hbase-mapreduce hbase-shaded hbase-shaded/hbase-shaded-client hbase-assembly hbase-assembly-byo-hadoop hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6969/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain NihalJain merged commit 82a2ddf into apache:master May 20, 2025
1 check was pending
NihalJain added a commit to NihalJain/hbase that referenced this pull request May 20, 2025
*  Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
NihalJain added a commit that referenced this pull request May 20, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

(cherry picked from commit 82a2ddf)
NihalJain added a commit to NihalJain/hbase that referenced this pull request May 20, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

 (cherry picked from commit 82a2ddf)
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 6m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 28s master passed
+1 💚 compile 3m 4s master passed
+1 💚 javadoc 5m 59s master passed
+1 💚 shadedjars 7m 25s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 55s the patch passed
+1 💚 compile 2m 58s the patch passed
+1 💚 javac 2m 58s the patch passed
+1 💚 javadoc 4m 41s the patch passed
+1 💚 shadedjars 6m 39s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 348m 18s /patch-unit-root.txt root in the patch failed.
401m 35s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6969/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6969
Optional Tests javac javadoc unit compile shadedjars
uname Linux e7489e58c584 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0e0a480
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6969/4/testReport/
Max. process+thread count 5380 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-server hbase-mapreduce hbase-shaded hbase-shaded/hbase-shaded-client hbase-assembly hbase-assembly-byo-hadoop hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6969/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain added a commit to NihalJain/hbase that referenced this pull request May 22, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

 (cherry picked from commit 82a2ddf)
NihalJain added a commit to NihalJain/hbase that referenced this pull request May 23, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

 (cherry picked from commit 82a2ddf)
NihalJain added a commit to NihalJain/hbase that referenced this pull request May 23, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

 (cherry picked from commit 82a2ddf)
NihalJain added a commit that referenced this pull request May 27, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

 (cherry picked from commit 82a2ddf)
NihalJain added a commit that referenced this pull request May 27, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

 (cherry picked from commit 82a2ddf)
NihalJain added a commit that referenced this pull request May 27, 2025
* Move from `io.opentelemetry:opentelemetry-semconv` to relocated groupid `io.opentelemetry.semconv:opentelemetry-semconv` and change imports accordingly.
* Refactoring to keep all semantic attributes inside `HBaseSemanticAttributes`
* Add appropriate excludes and includes for renamed groupid `io.opentelemetry.semconv:opentelemetry-semconv` from `io.opentelemetry:opentelemetry-semconv`

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

(cherry picked from commit 82a2ddf)
kravii added a commit to acceldata-io/hbase that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants