HBASE-29273 Remove deprecated boxed primitive constructors in some test classes #6949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the use of deprecated boxed primitive constructors in various test classes as part of HBASE-29273, ensuring more modern and idiomatic Java usage in tests.
- Replaces deprecated constructors in TestLogRolling, TestScannerWithBulkload, TestDeadServer, TestHFileDataBlockEncoder, TestTimestampsFilter, and TestMultiParallel.
- Updates object boxing to use autoboxing or factory methods such as Integer.valueOf and Long.valueOf.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java | Removed deprecated new Integer(1) usage in favor of literal 1. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerWithBulkload.java | Replaced new Long(9999999) with Long.valueOf(9999999). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java | Updated new Long values to Long.valueOf for assertions. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java | Removed deprecated new Boolean(...) usage by directly passing includesMemstoreTS. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTimestampsFilter.java | Changed new Long(3) to 3L in timestamp addition. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java | Replaced new Integer(...) with Integer.valueOf(...). |
Comments suppressed due to low confidence (2)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java:146
- [nitpick] Consider simplifying the integer to byte conversion by using a direct cast, e.g., (byte)(i % 256), which improves readability.
cp[k.length] = Integer.valueOf(i % 256).byteValue();
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java:159
- [nitpick] Consider simplifying the integer to byte conversion by using a direct cast, e.g., (byte)(i % 256), which improves readability.
cp[k.length] = Integer.valueOf(i % 256).byteValue();
guluo2016
commented
Apr 28, 2025
| @@ -143,7 +143,7 @@ private static byte[][] makeKeys() { | |||
| byte[] k = starterKeys[kIdx]; | |||
| byte[] cp = new byte[k.length + 1]; | |||
| System.arraycopy(k, 0, cp, 0, k.length); | |||
| cp[k.length] = new Integer(i % 256).byteValue(); | |||
| cp[k.length] = Integer.valueOf(i % 256).byteValue(); | |||
There was a problem hiding this comment.
Thanks @Apache9 for triggering the GitHub Copilot review!
These nitpicks seem reasonable in here and i will apply the changes.
This comment has been minimized.
This comment has been minimized.
Apache9
approved these changes
May 22, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
guluo2016
force-pushed
the
hbase_HBASE-29273
branch
from
60cb790 to
ff45659
Compare
|
Squashed the commits and trigger a rebuild. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Jun 5, 2025
…st classes (#6949) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit d84824b)
Apache9
pushed a commit
that referenced
this pull request
Jun 5, 2025
…st classes (#6949) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit d84824b)
Apache9
pushed a commit
that referenced
this pull request
Jun 5, 2025
…st classes (#6949) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit d84824b)
Apache9
pushed a commit
that referenced
this pull request
Jun 5, 2025
…st classes (#6949) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit d84824b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-29273