Skip to content

Conversation

@zhtttylz
Copy link
Contributor

Description of PR

HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version upgrade.

How was this patch tested?

Ran mvn -Dspotbugs.skip=false spotbugs:spotbugs on affected modules and verified the build no longer fails on SpotBugs warnings. No functional code changes, config-only.

For code changes:

  • Add a project-wide baseline at dev-support/findbugs-exclude-global.xml.
  • Consolidate SpotBugs plugin config in affected module POMs to consistently include local excludes and the new global baseline.
  • Wire the global baseline from hadoop-project-dist/pom.xml; introduce a root path property to reference the repository root.

@slfan1989
Copy link
Contributor

@zhtttylz Thank you for following up on this issue.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 8m 39s Maven dependency ordering for branch
+1 💚 mvninstall 15m 41s trunk passed
+1 💚 compile 8m 19s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 8m 22s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
-1 ❌ mvnsite 6m 23s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 5m 21s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 4m 44s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 71m 43s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 25m 51s the patch passed
+1 💚 compile 8m 1s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 8m 1s the patch passed
+1 💚 compile 8m 20s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 8m 20s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-1 ❌ mvnsite 3m 41s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 5m 15s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 4m 38s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 28m 29s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 589m 16s /patch-unit-root.txt root in the patch passed.
-1 ❌ asflicense 0m 48s /results-asflicense.txt The patch generated 1 ASF License warnings.
734m 52s
Reason Tests
Failed junit tests hadoop.yarn.server.router.subcluster.capacity.TestYarnFederationWithCapacityScheduler
hadoop.security.ssl.TestDelegatingSSLSocketFactory
hadoop.yarn.sls.appmaster.TestAMSimulator
hadoop.hdfs.TestDecommission
hadoop.hdfs.tools.TestDFSAdmin
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8053/2/artifact/out/Dockerfile
GITHUB PR #8053
Optional Tests dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient
uname Linux 2197de4c49c9 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c46c6af
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8053/2/testReport/
Max. process+thread count 4391 (vs. ulimit of 5500)
modules C: hadoop-project-dist hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-nfs hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-mapreduce-project hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-tools/hadoop-fs2img hadoop-tools/hadoop-gcp hadoop-tools/hadoop-benchmark hadoop-cloud-storage-project/hadoop-cos hadoop-cloud-storage-project/hadoop-huaweicloud hadoop-cloud-storage-project/hadoop-tos . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8053/2/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 14m 34s Docker failed to build run-specific yetus/hadoop:tp-29464}.
Subsystem Report/Notes
GITHUB PR #8053
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8053/4/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants