Skip to content

Conversation

vinayakumarb
Copy link
Contributor

  • Adds recheck of current state before invoking transitionToStandBy() in a new thread.
  • This re-check avoids setting of StandByTransitionRunnable#hasAlreadyRun = true when the state is already StandBy.
  • This fix, allows proper transitionToStandby() when RMStateStore reaches FENCED state.

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending pre-commits. Thank you @vinayakumarb !

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slfan1989
Copy link
Contributor

@vinayakumarb Thanks for the contribution! We can re-trigger the build. The crash issue in the YARN ResourceManager JUnit test has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants