-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19616. Add bswap support for RISC-V #7809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Hi @ayushtkn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 -1 overall
This message was automatically generated. |
For some reason mvn install is failing in the CI, can u rebase your PR |
Hi, I already rebased the PR yesterday.
Could you help resolve this? Thank you! |
Thanks for the review and merge. |
Description of PR
While building Hadoop native code on the riscv64 architecture, the build fails due to missing support for bswap operations. The standard implementation relies on compiler intrinsics or platform-specific assembly which are not defined for RISC-V targets.
This results in compilation errors such as:
Add bswap support for RISC-V can solve the problem.
How was this patch tested?
mvn package -Pdist,native -DskipTests -Dtar
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?