-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11829. Added retry to release file handler #7755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's handle the folder deletion reliably.
throw new IOException("Failed to delete directory after retries: " + d.getAbsolutePath(), e); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still may not guarantee the folder deletion. A better way to solve this would be to configure this class to never run the unit tests in parallel. You can use the @Execution(ExecutionMode.SAME_THREAD)
annotation on the class in JUnit 5.
Could you please use an equivalent approach for the version of JUnit used here?
Description of PR
UTs in yarn-resourcemanager is failing with below error:
The above error shows up when all the UTs for class
TestFSConfigToCSConfigConverter
runs together as we are using same folder structure which is being created/deleted after every test case.The issue happens when the file handlers are not closed properly resulting in unsuccessful deletion of test directory.
How was this patch tested?
The patch was tested by running UTs in local.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?