GUACAMOLE-377: Address performance regression primarily affecting RDP. #573
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I notice a significant improvement in performance; however, when moving a window (especially during fast movements), there can be some "mixing" that I cannot reproduce without the fix. Here is a preview: I find it harder to reproduce on a Linux VM (GNOME RDP) than on a Windows with the same configuration. Freerdp3 with this configuration: |
|
@corentin-soriano I remember seeing those artifacts before. I think what you're seeing is due to a timing-related bug that's present regardless of these changes, and it's just that these changes make that bug more likely to appear. |
|
@mike-jumper I suspected it was linked to the speed gain but I preferred to have confirmation. |
…forward. This seems to induce latency and possibly negatively affects tracking of client-side processing lag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address two issues that were affecting the performance of Guacamole after the introduction of
guac_display, particularly RDP:The dirty rects of the last frame were not being updated when the corresponding dirty rects of the pending frame were empty.
It's correct to not flush updated image data if the dirty rects are empty, but the rects tracking the state of the last frame need to be correctly updated to match the state of the pending frame, even if that state is empty. Doing otherwise results in unnecessary updates being transmitted to the client, since
guac_displayincorrectly believes that things were changed in the last frame.Sending a new
syncfor each movement of the mouse can at least cause client-side slowdowns. There may be things that can be improved in the client.Additional changes related to this are part of apache/guacamole-client#1045.