Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove incorrect @VisibleForTesting annotation & apply Spotless formatting #6571

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Brijeshthummar02
Copy link
Contributor

@Brijeshthummar02 Brijeshthummar02 commented Feb 27, 2025

Title:

[#6529 ] fix: Remove incorrect @VisibleForTesting annotation & apply Spotless formatting


What changes were proposed in this pull request?

  • Removed incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED.
  • Applied Spotless formatting to multiple files (README.md, docs/, gradle-wrapper.properties, gradlew).

Why are the changes needed?

  • The @VisibleForTesting annotation was incorrectly added to ICEBERG_CATALOG_CACHE_ENABLED, which is a public constant and does not require this annotation.
  • Spotless ensures code consistency and formatting, avoiding CI failures.

Does this PR introduce any user-facing change?

No, this PR does not introduce any user-facing changes. It only includes formatting fixes and annotation removal.


How was this patch tested?

  • Ran ./gradlew :spark-connector:spark-common:spotlessApply to format the code.
  • Verified changes using git diff to ensure only formatting and annotation removal.
  • Ensured that the CI check passes after applying the fixes.

Fix Reference:

Fixes #6529
Related PR: #6532


Screenshot 2025-02-27 221133

Additional

Screenshot 2025-02-27 220507
Screenshot 2025-02-27 220522
Screenshot 2025-02-27 221117

@Brijeshthummar02
Copy link
Contributor Author

@justinmclean much clean now??

#6532 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] In IcebergPropertiesConverter.java use of @VisibleForTesting constant
1 participant