[#6375] improvment(catalog-hadoop): Remove protobuf-java to avoid conflict with authorization module
#6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Jan 27, 2025
| @@ -52,6 +52,8 @@ dependencies { | |||
| exclude("org.eclipse.jetty", "*") | |||
| exclude("io.netty") | |||
| exclude("org.fusesource.leveldbjni") | |||
| // Exclude protobuf-java to avoid conflict with; | |||
| exclude("com.google.protobuf", "protobuf-java") | |||
There was a problem hiding this comment.
is it still useful as you exclude the package in copy task
There was a problem hiding this comment.
Is exclude the protobuf-java in copy task is more general solution? since other package may introduce protobuf-java too.
There was a problem hiding this comment.
I'm afraid excluding it in the gradle dependencies may be more general.
since other package may introduce protobuf-java too.
Some modules use copy task to exclude jars because using excluding in gradle does not work. I believe this is not a very elegant behaviour.
FANNG1
reviewed
Jan 27, 2025
FANNG1
reviewed
Feb 5, 2025
| @@ -52,6 +52,8 @@ dependencies { | |||
| exclude("org.eclipse.jetty", "*") | |||
| exclude("io.netty") | |||
| exclude("org.fusesource.leveldbjni") | |||
| // Exclude protobuf-java to avoid conflict with; | |||
There was a problem hiding this comment.
The comment is not complete?
|
@yuqi1129 can you please update this PR? |
FANNG1
approved these changes
Feb 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…onflict with authorization module (#6376) ### What changes were proposed in this pull request? Remove jar `protobuf-java.jar` from the distribution package to avoid conflicts ### Why are the changes needed? To make authorization works for GCS fileset. Fix: #6375 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? N/A
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Feb 6, 2025
…void conflict with authorization module (apache#6376) ### What changes were proposed in this pull request? Remove jar `protobuf-java.jar` from the distribution package to avoid conflicts ### Why are the changes needed? To make authorization works for GCS fileset. Fix: apache#6375 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove jar
protobuf-java.jarfrom the distribution package to avoid conflictsWhy are the changes needed?
To make authorization works for GCS fileset.
Fix: #6375
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
N/A