[#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diqiu50
changed the title
tengqm
reviewed
Jan 20, 2025
| config: Option<String>, | ||
|
|
||
| #[arg(short, long, help = "Debug level", default_value_t = 0)] | ||
| debug: u8, |
There was a problem hiding this comment.
Looks like this is an overdesign?
Are we really using this argument?
There was a problem hiding this comment.
Yes, we will need to use this argument in PR #5905.
Co-authored-by: Qiming Teng <[email protected]>
FANNG1
reviewed
Feb 5, 2025
FANNG1
reviewed
Feb 5, 2025
| mount_point: String, | ||
|
|
||
| #[arg(help = "The URI of the GVFS fileset")] | ||
| location: String, |
There was a problem hiding this comment.
The meaning of location and config seems not clear
There was a problem hiding this comment.
Change location to fileset_location
Using "config" as a configuration name is very common.
There was a problem hiding this comment.
could you provide an example of fileset_location and add the example to the help message?
There was a problem hiding this comment.
help message like:
./gvfs-fuse mount --help
Usage: gvfs-fuse mount [OPTIONS] <MOUNT_POINT> <FILESET_LOCATION>
Arguments:
<MOUNT_POINT> Mount point for the filesystem
<FILESET_LOCATION> The URI of the GVFS fileset, like gvfs://fileset/my_catalog/my_schema/my_fileset
Options:
-c, --config <CONFIG> Path to the configuration file
-d, --debug <DEBUG> Debug level [default: 0]
-f, --foreground Run in foreground
-h, --help Print help
There was a problem hiding this comment.
isFILESET_URI more meaningful than FILESET_LOCATION?
FANNG1
reviewed
Feb 7, 2025
FANNG1
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #6320
Does this PR introduce any user-facing change?
No
How was this patch tested?
IT