Skip to content

Disable Jansi in generated logback-spring.xml to fix console logging after DevTools restart #15694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesfredley wants to merge 3 commits into
base: 7.0.x
Choose a base branch
from
+17 −11
Open

Disable Jansi in generated logback-spring.xml to fix console logging after DevTools restart #15694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1029297
Disable Jansi in generated logback-spring.xml to fix console logging …
jamesfredley May 29, 2026
e0fe2ac
Merge branch '7.0.x' into fix/forge-logback-withjansi-devtools
jamesfredley May 29, 2026
ab395d6
Merge branch '7.0.x' into fix/forge-logback-withjansi-devtools
jamesfredley Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/logging/Logback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import jakarta.inject.Singleton;
import org.grails.forge.application.ApplicationType;
import org.grails.forge.application.OperatingSystem;
import org.grails.forge.application.generator.GeneratorContext;
import org.grails.forge.build.dependencies.Dependency;
import org.grails.forge.feature.DefaultFeature;
Expand Down Expand Up @@ -61,17 +60,10 @@ public boolean shouldApply(ApplicationType applicationType, Options options, Set

@Override
public void apply(GeneratorContext generatorContext) {
OperatingSystem operatingSystem = generatorContext.getOperatingSystem();
boolean jansi = false;

if (operatingSystem != OperatingSystem.WINDOWS) {

@jdaugherty jdaugherty Jun 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks color logging on other OSs. I don't agree with this solution.

jansi = true;
}

String projectName = generatorContext.getProject().getName();
String packageName = generatorContext.getProject().getPackageName();

generatorContext.addTemplate("loggingConfig", new RockerTemplate("grails-app/conf/logback-spring.xml", logback.template(projectName, packageName, jansi)));
generatorContext.addTemplate("loggingConfig", new RockerTemplate("grails-app/conf/logback-spring.xml", logback.template(projectName, packageName)));
generatorContext.addDependency(Dependency.builder()
.groupId("org.apache.grails")
.artifactId("grails-logging")
Expand Down
4 changes: 2 additions & 2 deletions ...ils-forge-core/src/main/java/org/grails/forge/feature/logging/template/logback.rocker.raw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ specific language governing permissions and limitations
under the License.
*@

@args (String projectName, String packageName, boolean jansi)
@args (String projectName, String packageName)

<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<include resource="org/springframework/boot/logging/logback/defaults.xml"/>

<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
<withJansi>@jansi</withJansi>
<withJansi>false</withJansi>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>${CONSOLE_LOG_THRESHOLD}</level>
</filter>
Expand Down
14 changes: 14 additions & 0 deletions ...rge/grails-forge-core/src/test/groovy/org/grails/forge/feature/logging/LogbackSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,18 @@ class LogbackSpec extends ApplicationContextSpec implements CommandOutputFixture
where:
applicationType << ApplicationType.values().toList()
}

@Unroll
void "test logback-spring.xml disables Jansi for #applicationType application"() {
when:
def output = generate(applicationType, new Options(DevelopmentReloading.DEVTOOLS))

then: "Jansi is disabled so its global System.out replacement does not break console logging after a Spring Boot DevTools restart (issue #15663)"
def logback = output.get("grails-app/conf/logback-spring.xml")
logback.contains("<withJansi>false</withJansi>")
!logback.contains("<withJansi>true</withJansi>")

where:
applicationType << ApplicationType.values().toList()
}
}
Loading