Skip to content

[GOBBLIN-2235] Remove helix jobs mapping from temporal job scheduler #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Blazer-007 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[GOBBLIN-2235] Remove helix jobs mapping from temporal job scheduler #4150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f704cd
remove helix jobs mapping from temporal job scheduler
Blazer-007 Oct 30, 2025
8411ec3
remove unused imports
Blazer-007 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions ...al/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.apache.gobblin.annotation.Alpha;
import org.apache.gobblin.cluster.GobblinClusterConfigurationKeys;
import org.apache.gobblin.cluster.GobblinHelixJob;
import org.apache.gobblin.cluster.HelixJobsMapping;
import org.apache.gobblin.cluster.event.CancelJobConfigArrivalEvent;
import org.apache.gobblin.cluster.event.DeleteJobConfigArrivalEvent;
import org.apache.gobblin.cluster.event.NewJobConfigArrivalEvent;
Expand All @@ -52,8 +51,6 @@
import org.apache.gobblin.scheduler.SchedulerService;
import org.apache.gobblin.temporal.GobblinTemporalConfigurationKeys;
import org.apache.gobblin.util.ConfigUtils;
import org.apache.gobblin.util.PathUtils;
import org.apache.gobblin.util.PropertiesUtils;
import org.apache.gobblin.util.reflection.GobblinConstructorUtils;


Expand All @@ -79,8 +76,6 @@ public class GobblinTemporalJobScheduler extends JobScheduler implements Standar
private final MetricContext metricContext;
final GobblinTemporalJobSchedulerMetrics jobSchedulerMetrics;
final GobblinTemporalJobLauncherMetrics launcherMetrics;
final GobblinTemporalPlanningJobLauncherMetrics planningJobLauncherMetrics;
final HelixJobsMapping jobsMapping;
private boolean startServicesCompleted;

public GobblinTemporalJobScheduler(Config sysConfig,
Expand Down Expand Up @@ -108,22 +103,13 @@ public GobblinTemporalJobScheduler(Config sysConfig,
this.metricContext,
metricsWindowSizeInMin);

this.jobsMapping = new HelixJobsMapping(ConfigUtils.propertiesToConfig(properties),
PathUtils.getRootPath(appWorkDir).toUri(),
appWorkDir.toString());

this.planningJobLauncherMetrics = new GobblinTemporalPlanningJobLauncherMetrics("planningLauncherInScheduler",
this.metricContext,
metricsWindowSizeInMin, this.jobsMapping);

this.startServicesCompleted = false;
}

@Override
public Collection<StandardMetrics> getStandardMetricsCollection() {
return ImmutableList.of(this.launcherMetrics,
this.jobSchedulerMetrics,
this.planningJobLauncherMetrics);
this.jobSchedulerMetrics);
}

@Override
Expand Down Expand Up @@ -153,18 +139,6 @@ public void scheduleJob(Properties jobProps, JobListener jobListener) throws Job

@Override
protected void startServices() throws Exception {

boolean cleanAllDistJobs = PropertiesUtils.getPropAsBoolean(this.properties,
GobblinClusterConfigurationKeys.CLEAN_ALL_DIST_JOBS,
String.valueOf(GobblinClusterConfigurationKeys.DEFAULT_CLEAN_ALL_DIST_JOBS));

if (cleanAllDistJobs) {
for (org.apache.gobblin.configuration.State state : this.jobsMapping.getAllStates()) {
String jobUri = state.getId();
LOGGER.info("Delete mapping for job " + jobUri);
this.jobsMapping.deleteMapping(jobUri);
}
}
}

@Override
Expand Down
Loading