[GOBBLIN-2144] Prevent GenerateWorkUnitsImpl
from inadvertently cleaning up temp/staging dirs
#4039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Whereas the
AbstractJobLauncher
, used by Gobblin-on-MR, runs the entire job end-to-end, the Gobblin-on-TemporalGenerateWorkUnitsImpl
activity solely generates WUs w/o actually processing them. Thus it's far too early to clean anything up in the temp/staging dirs (e.g. task-staging and task-output, used by writers and the commit step).Even worse, depending upon config, doing cleanup nonetheless could destabilize other job executions, when those share this same temp/staging area. Such cross-job "action-at-a-distance" is unpredictable and especially challenging even to diagnose.
Tests
./gradlew build
successfulCommits