Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2047] Gracefully handle duplicate dagAction entry insertion #3926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

umustafi
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    If a previous dagAction has not been processed already (in the event of service downtime for example), then we want to gracefully handle an attempt to re-add the same action by ignoring the add and completing the MALA lease.
java.lang.RuntimeException: java.io.IOException: Failure adding action for DagAction: DagActionStore.DagAction(flowGroup=FILE_BASED_COPY-mufn, flowName=mufn-holdem_1792467993, flowExecutionId=1713211305981, jobName=, dagActionType=LAUNCH) in table dag_action_store
java.io.IOException: Failure adding action for DagAction: DagActionStore.DagAction(flowGroup=FILE_BASED_COPY-mufn, flowName=mufn-holdem_1792467993, flowExecutionId=1713211305981, jobName=, dagActionType=LAUNCH) in table dag_action_store
java.sql.SQLIntegrityConstraintViolationException: Duplicate entry 'FILE_BASED_COPY-mufn-mufn-holdem_1792467993-1713211305981-LAUNCH' for key 'dag_action_store.PRIMARY'

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant