-
Notifications
You must be signed in to change notification settings - Fork 590
[GLUTEN-6887][VL] Daily Update Velox Version (2026_04_01) #11860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fe79614
36bf7c3
4c29b7e
5870178
b0c53d3
f590514
48dd3d8
ac91ab2
75e6871
e7f9ba4
4d99fd3
df9b816
27e83cf
7384ed2
e4499a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,7 +133,7 @@ class GlutenEliminateJoinSuite extends GlutenClickHouseWholeStageTransformerSuit | |
| }) | ||
| } | ||
|
|
||
| test("Eliminate two aggregate joins with attribute reordered") { | ||
| ignore("Eliminate two aggregate joins with attribute reordered") { | ||
| val sql = """ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zzcclp this test failed, it's not related with this patch, seems due to the recent changes in the past two weeks
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will take a look next week. |
||
| select t1.k1, t1.k3, t2.k1, t2.k3, s1, s2 from ( | ||
| select k1, k3, sum(v1) s1 from ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,8 @@ class GlutenParquetThriftCompatibilitySuite | |
| getWorkspaceFilePath("sql", "core", "src", "test", "resources").toString + | ||
| "/test-data/parquet-thrift-compat.snappy.parquet" | ||
|
|
||
| testGluten("Read Parquet file generated by parquet-thrift") { | ||
| // TODO: https://github.com/apache/gluten/issues/11865 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @baibaichen seems due to missing fix from one old OAP patch: https://github.com/IBM/velox/pull/35/changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's in baibaichen/velox@9f58f05
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. waiting for facebookincubator/velox#16966 |
||
| ignoreGluten("Read Parquet file generated by parquet-thrift") { | ||
| logInfo(s"""Schema of the Parquet file written by parquet-thrift: | ||
| |${readParquetSchema(parquetFilePath.toString)} | ||
| """.stripMargin) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzcclp