[VL] Fix streaming UTs by copying tags in EnsureLocalSortRequirements#11859
Open
minni31 wants to merge 1 commit intoapache:mainfrom
Open
[VL] Fix streaming UTs by copying tags in EnsureLocalSortRequirements#11859minni31 wants to merge 1 commit intoapache:mainfrom
minni31 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
When EnsureLocalSortRequirements adds a local SortExec to satisfy required child ordering, the new SortExec node was missing tags from the original child. This caused streaming test failures because StateStoreWriter and other stateful operators rely on tags (e.g., isStatefulOperatorStreamingRestore) to propagate streaming execution metadata. Fix: Call newChild.copyTagsFrom(originalChild) to preserve tags when wrapping a child plan with SortExec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
minni31
force-pushed
the
oss/fix-streaming-ut-sort-tags
branch
from
3f2baab to
c5dfede
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes streaming-related test suite failures for Spark 4.0 and 4.1 by preserving plan node tags when
EnsureLocalSortRequirementswraps a child withSortExec.Problem
When
EnsureLocalSortRequirementscreates a newSortExecto satisfy required child ordering, the new node was missing tags from the original child plan. This caused failures in streaming test suites because stateful operators (e.g.,StateStoreWriter,TransformWithState) rely on tags to propagate streaming execution metadata such asisStatefulOperatorStreamingRestore.Affected test suites include:
FlatMapGroupsWithStateSuiteTransformWithListStateSuite/TransformWithListStateTTLSuiteTransformWithMapStateTTLSuiteTransformWithStateChainingSuite/TransformWithStateInitialStateSuiteTransformWithValueStateTTLSuiteOperatorStateMetadataSuiteStateDataSourceread suitesRocksDBStateStoreCheckpointFormatV2SuiteFix
One-line fix: call
newChild.copyTagsFrom(originalChild)after creating theSortExecto preserve tags from the original child plan.Testing
Streaming test suites that were previously failing now pass with this fix.