Skip to content

[GLUTEN-11849][CH] Fix diff for var_samp returns NaN instead of NULL when effective row count < 2 #11850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exmy wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

[GLUTEN-11849][CH] Fix diff for var_samp returns NaN instead of NULL when effective row count < 2 #11850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...nds-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseTPCHSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,14 @@ class GlutenClickHouseTPCHSuite extends MergeTreeSuite {

}

test("var_samp returns null instead of NaN") {
val sql1 = "select var_samp(id) from range(1)"
val sql2 = "select covar_samp(id, id) from range(1)"

compareResultsAgainstVanillaSpark(sql1, true, { _ => })
compareResultsAgainstVanillaSpark(sql2, true, { _ => })
}

test("existence join") {
spark.sql("create table t1(a int, b int) using parquet")
spark.sql("create table t2(a int, b int) using parquet")
Expand Down
4 changes: 3 additions & 1 deletion cpp-ch/local-engine/Parser/AggregateFunctionParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ const DB::ActionsDAG::Node * AggregateFunctionParser::convertNodeTypeIfNeeded(
const DB::ActionsDAG::Node * AggregateFunctionParser::convertNanToNullIfNeed(
const CommonFunctionInfo & func_info, const DB::ActionsDAG::Node * func_node, DB::ActionsDAG & actions_dag) const
{
if (getCHFunctionName(func_info) != "corr" || !func_node->result_type->isNullable())
const auto function_name = getCHFunctionName(func_info);
if ((function_name != "corr" && function_name != "varSamp" && function_name != "covarSamp")
|| !func_node->result_type->isNullable())
return func_node;

/// result is nullable.
Expand Down
Loading