Open
Conversation
infvg
force-pushed
the
icebergwriteconfigs
branch
2 times, most recently
from
96c80e3 to
a4db501
Compare
# Conflicts: # docs/velox-configuration.md
infvg
force-pushed
the
icebergwriteconfigs
branch
from
a4db501 to
5bf8aea
Compare
rui-mo
reviewed
Apr 2, 2026
Contributor
rui-mo
left a comment
rui-mo
left a comment
There was a problem hiding this comment.
Looks good to me. I’ll also loop in @jinchengchenghh for a final pass.
| .booleanConf | ||
| .createWithDefault(true) | ||
|
|
||
| val PARQUET_PAGE_SIZE_BYTES = |
Contributor
There was a problem hiding this comment.
Please remove the config, the config should not exposed to users, we should respect iceberg corresponding config, in this case, please update the config map as https://github.com/apache/gluten/blob/main/backends-velox/src-iceberg/main/scala/org/apache/gluten/execution/AbstractIcebergWriteExec.scala#L37
Please find the codec path, and set to Velox config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for:
write.target-file-size-bytes,write.parquet.page-size-bytesResolves part of #11703