Skip to content

GEODE-10696: Select JDK in prepare_rc.sh based on release version #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JinwooHwang wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GEODE-10696: Select JDK in prepare_rc.sh based on release version #8151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions dev-tools/release/prepare_rc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,21 @@ echo ""
echo "============================================================"
echo "Checking java..."
echo "============================================================"
# Geode 1.x releases are built with JDK 8; 2.x and later are built with JDK 17.
if [[ ${VERSION%%.*} -lt 2 ]]; then
JAVA_SPEC_VERSION=1.8
JDK_NAME="JDK 8"
else
JAVA_SPEC_VERSION=17
JDK_NAME="JDK 17"
fi
[ -z "$JAVA_HOME" ] && JAVA=java || JAVA=$JAVA_HOME/bin/java
if ! $JAVA -XshowSettings:properties -version 2>&1 | grep 'java.specification.version = 17' ; then
echo "Please set JAVA_HOME to use JDK 17 to compile Geode for release"
if ! $JAVA -XshowSettings:properties -version 2>&1 | grep "java.specification.version = ${JAVA_SPEC_VERSION}" ; then
echo "Please set JAVA_HOME to use ${JDK_NAME} to compile Geode ${VERSION} for release"
exit 1
fi
if $JAVA -XshowSettings:properties -version 2>&1 | grep 'java.vm.vendor = Oracle' ; then
echo "Please set JAVA_HOME to use an Open JDK 17 such as from https://adoptium.net to compile Geode for release"
echo "Please set JAVA_HOME to use an Open ${JDK_NAME} such as from https://adoptium.net to compile Geode ${VERSION} for release"
exit 1
else
$JAVA -XshowSettings:properties -version 2>&1 | grep 'java.vm.vendor = '
Expand Down
Loading