Skip to content

[flink] Fix data lake catalog connection resource is not closed in flink catalog #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhuangchong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[flink] Fix data lake catalog connection resource is not closed in flink catalog #2087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fluss-common/src/main/java/org/apache/fluss/metadata/TableChange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
public interface TableChange {

/**
* A table change toadd the column with specified position.
* A table change to add the column with specified position.
*
* <p>It is equal to the following statement:
*
Expand Down
1 change: 1 addition & 0 deletions ...s-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ public void open() throws CatalogException {
public void close() throws CatalogException {
IOUtils.closeQuietly(admin, "fluss-admin");
IOUtils.closeQuietly(connection, "fluss-connection");
IOUtils.closeQuietly(lakeFlinkCatalog, "fluss-lake-catalog");
}

@Override
Expand Down
9 changes: 8 additions & 1 deletion ...-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/lake/LakeFlinkCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import static org.apache.fluss.utils.Preconditions.checkNotNull;

/** A lake flink catalog to delegate the operations on lake table. */
public class LakeFlinkCatalog {
public class LakeFlinkCatalog implements AutoCloseable {

private final String catalogName;
private final ClassLoader classLoader;
Expand Down Expand Up @@ -93,6 +93,13 @@ public DataLakeFormat getLakeFormat() {
return lakeFormat;
}

@Override
public void close() throws Exception {
if (catalog != null) {
catalog.close();
}
}

/**
* Factory for creating Paimon Catalog instances.
*
Expand Down