Skip to content

Conversation

@KaranPradhan266
Copy link
Contributor

Purpose

Linked issue: close #79

Brief change log

Completed all todo!() placeholders in GenericRow’s InternalRow implementation: numeric getters (get_boolean through get_double) now use try_into, get_char enforces fixed-length semantics, and get_binary/get_bytes clone data via as_blob().

Tests

N/A

API and Format

N/A

Documentation

N/A

@KaranPradhan266 KaranPradhan266 changed the title implemented methods todo() methods for GenericRow implemented all get methods for GenericRow Dec 8, 2025
@luoyuxia luoyuxia requested a review from Copilot December 9, 2025 08:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the implementation of all getter methods in the GenericRow struct's InternalRow trait implementation. The changes replace todo!() placeholders with functional implementations using the try_into() pattern for type conversions and add the necessary supporting infrastructure in the Datum enum.

Key changes:

  • Implemented numeric getters (get_boolean, get_byte, get_short, get_float, get_double) using try_into() conversions
  • Implemented get_char with fixed-length validation via panic on mismatch
  • Implemented binary data getters (get_binary, get_bytes) using a new as_blob() helper method
  • Added Int8 variant to Datum enum with complete trait implementations (From, TryFrom, ToArrow)
  • Added as_blob() helper method to Datum for binary data access

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
crates/fluss/src/row/mod.rs Implements all previously unimplemented getter methods in GenericRow's InternalRow trait, using unwrap-based error handling consistent with existing patterns
crates/fluss/src/row/datum.rs Adds Int8 variant to Datum enum, implements as_blob() helper, and adds all necessary From/TryFrom trait implementations for new type support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@luoyuxia
Copy link
Contributor

@KaranPradhan266 Thank you for the pr. Merging...

@luoyuxia luoyuxia merged commit e9f1cc4 into apache:main Dec 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement all get method for GenericRow

2 participants