[chore] Implement datatype conversion for all types in arrow.rs #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoyuxia
reviewed
Dec 9, 2025
There was a problem hiding this comment.
Pull request overview
This PR implements Arrow datatype conversions for previously unimplemented Fluss types (Decimal, Time, Timestamp, TimestampLTz, Bytes, Binary) in the to_arrow_type function. This completes the type mapping functionality needed for Arrow serialization/deserialization, addressing issue #78.
Key changes:
- Adds Decimal128 conversion with precision/scale mapping
- Implements Time/Timestamp type conversions with precision-based TimeUnit selection
- Adds Binary and Bytes type mappings to Arrow binary types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
reviewed
Dec 11, 2025
| .expect("length exceeds i32::MAX"), | ||
| ), | ||
| DataType::Array(arrow_type) => ArrowDataType::List( | ||
| arrow_schema::Field::new_list_field(to_arrow_type(arrow_type.get_element_type()), true) |
Contributor
There was a problem hiding this comment.
nit:
consider nullable of arrow_type
| let key_type = to_arrow_type(map_type.key_type()); | ||
| let value_type = to_arrow_type(map_type.value_type()); | ||
| let entry_fields = vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #78
Brief change log
Tests
API and Format
Documentation