[FLINK-40169][table] Add target option to the EARLY_FIRE hint#28827
Draft
weiqingy wants to merge 2 commits into
Draft
[FLINK-40169][table] Add target option to the EARLY_FIRE hint#28827weiqingy wants to merge 2 commits into
weiqingy wants to merge 2 commits into
Conversation
Add an optional `target` option to the EARLY_FIRE join hint. Only `interval_join` is accepted today; any other value fails planning. An omitted target is equivalent to `interval_join`, so existing hints keep their meaning. `target` scopes the hint to a single operator kind. The interval-join rule consumes the hint only when it targets the interval join and leaves a hint aimed at another operator kind untouched, so an untargeted hint never silently expands its scope.
Collaborator
Contributor
Author
|
Hi @RocMarshal, opening PR-2 of the FLIP-497 stack early as a draft so it's queued behind #28796. Since it's stacked, the commit list and diff here also carry #28796's commit for now. Once that one is merged I'll rebase this onto master, leaving only the Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the FLIP-497 implementation stack under umbrella FLINK-36953. Landing order:
targetoptionOpened as a draft because it is stacked on #28796, which is approved and awaiting merge. Until that lands, the commit list and diff here also carry PR-1b's commit. Once #28796 merges I will rebase onto master, leaving only this PR's change, and take it out of draft.
What is the purpose of the change
Adds an optional
targetoption to theEARLY_FIREhint so a hint can be explicitly scoped to a single operator kind. Onlyinterval_joinis accepted today, and an omittedtargetmeansinterval_join, so existing hints keep their meaning. This is a forward-compatibility guard: it keeps a bareEARLY_FIREhint from silently expanding its scope if other operators honor the hint in the future.Brief change log
EarlyFireJoinHintOptions.TARGET(optionalstringType) and theINTERVAL_JOINconstant.EARLY_FIREKV option checker validatestargetagainst the supported set. Any other value fails planning.StreamPhysicalIntervalJoinRuleapplies the hint only when it targets the interval join, and leaves a hint aimed at another operator kind untouched. That rule-level check is redundant with validation today, since an unsupported value already fails planning. It is there so that a hint aimed at a future operator kind is ignored by this rule rather than misapplied.Verifying this change
This change added tests and can be verified as follows:
EarlyFireJoinHintTest: an explicittarget='interval_join'still threadsearlyFireDelay/earlyFireTimeModeinto the exec plan, and an unsupportedtargetvalue fails planning with a message naming the supported set.Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes (a new option on the@PublicEvolvingEarlyFireJoinHintOptions)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Anthropic)