-
Notifications
You must be signed in to change notification settings - Fork 14k
[FLINK-38262][table] show connections operation #28790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shekharrajak
wants to merge
1
commit into
apache:master
Choose a base branch
from
Shekharrajak:FLINK-38262-show-connections-operation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
91 changes: 91 additions & 0 deletions
91
...le-api-java/src/main/java/org/apache/flink/table/operations/ShowConnectionsOperation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.operations; | ||
|
|
||
| import org.apache.flink.annotation.Internal; | ||
| import org.apache.flink.table.catalog.CatalogManager; | ||
| import org.apache.flink.table.operations.utils.ShowLikeOperator; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import java.util.Set; | ||
|
|
||
| import static org.apache.flink.util.Preconditions.checkNotNull; | ||
|
|
||
| /** | ||
| * Operation to describe a SHOW CONNECTIONS statement. The full syntax for SHOW CONNECTIONS is as | ||
| * follows: | ||
| * | ||
| * <pre>{@code | ||
| * SHOW CONNECTIONS [ ( FROM | IN ) [catalog_name.]database_name ] [[NOT] LIKE | ||
| * <sql_like_pattern>] | ||
| * }</pre> | ||
| */ | ||
| @Internal | ||
| public class ShowConnectionsOperation extends AbstractShowOperation { | ||
|
|
||
| private final @Nullable String databaseName; | ||
|
|
||
| public ShowConnectionsOperation( | ||
| @Nullable String catalogName, | ||
| @Nullable String databaseName, | ||
| @Nullable String preposition, | ||
| @Nullable ShowLikeOperator likeOp) { | ||
| super(catalogName, preposition, likeOp); | ||
| this.databaseName = databaseName; | ||
| } | ||
|
|
||
| public ShowConnectionsOperation( | ||
| @Nullable String catalogName, | ||
| @Nullable String databaseName, | ||
| @Nullable ShowLikeOperator likeOp) { | ||
| this(catalogName, databaseName, null, likeOp); | ||
| } | ||
|
|
||
| @Nullable | ||
| public String getDatabaseName() { | ||
| return databaseName; | ||
| } | ||
|
|
||
| @Override | ||
| protected Set<String> retrieveDataForTableResult(Context ctx) { | ||
| final CatalogManager catalogManager = ctx.getCatalogManager(); | ||
| return catalogManager.listConnections( | ||
| checkNotNull(catalogName, "catalogName"), | ||
| checkNotNull(databaseName, "databaseName")); | ||
| } | ||
|
|
||
| @Override | ||
| protected String getOperationName() { | ||
| return "SHOW CONNECTIONS"; | ||
| } | ||
|
|
||
| @Override | ||
| protected String getColumnName() { | ||
| return "connection name"; | ||
| } | ||
|
|
||
| @Override | ||
| public String getPrepositionSummaryString() { | ||
| if (databaseName == null) { | ||
| return super.getPrepositionSummaryString(); | ||
| } | ||
| return super.getPrepositionSummaryString() + "." + databaseName; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
...ava/org/apache/flink/table/planner/operations/converters/SqlShowConnectionsConverter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.operations.converters; | ||
|
|
||
| import org.apache.flink.sql.parser.dql.SqlShowConnections; | ||
| import org.apache.flink.table.operations.Operation; | ||
| import org.apache.flink.table.operations.ShowConnectionsOperation; | ||
| import org.apache.flink.table.operations.utils.ShowLikeOperator; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| /** A converter for {@link SqlShowConnections}. */ | ||
| public class SqlShowConnectionsConverter extends AbstractSqlShowConverter<SqlShowConnections> { | ||
|
|
||
| @Override | ||
| public Operation getOperationWithoutPrep( | ||
| SqlShowConnections sqlShowCall, | ||
| @Nullable String catalogName, | ||
| @Nullable String databaseName, | ||
| @Nullable ShowLikeOperator likeOp) { | ||
| return new ShowConnectionsOperation(catalogName, databaseName, likeOp); | ||
| } | ||
|
|
||
| @Override | ||
| public Operation getOperation( | ||
| SqlShowConnections sqlShowCall, | ||
| @Nullable String catalogName, | ||
| @Nullable String databaseName, | ||
| String prep, | ||
| @Nullable ShowLikeOperator likeOp) { | ||
| return new ShowConnectionsOperation(catalogName, databaseName, prep, likeOp); | ||
| } | ||
|
|
||
| @Override | ||
| public Operation convertSqlNode(SqlShowConnections sqlShowConnections, ConvertContext context) { | ||
| return convertShowOperation(sqlShowConnections, context); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we convert these into a single parametized test. WDYT?