-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-39110] Add CRT support in native-s3-fs #28136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Samrat002
wants to merge
1
commit into
apache:master
Choose a base branch
from
Samrat002:FLINK-39110
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -292,6 +292,27 @@ public class NativeS3FileSystemFactory implements FileSystemFactory { | |
| + "When not set, the default chain is used: delegation tokens -> " | ||
| + "static credentials (if configured) -> DefaultCredentialsProvider."); | ||
|
|
||
| public static final ConfigOption<Boolean> CRT_ENABLED = | ||
| ConfigOptions.key("s3.crt.enabled") | ||
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription( | ||
| "Enable AWS Common Runtime (CRT) HTTP transport. " | ||
| + "When true, uses AwsCrtHttpClient for sync S3 operations and " | ||
| + "S3AsyncClient.crtBuilder() for async/transfer operations, " | ||
| + "providing higher throughput for large S3 transfers. " | ||
| + "Requires aws-crt-client and aws-crt JARs in the plugin directory " | ||
| + "(they are not bundled in the fat JAR due to JNI shading constraints)."); | ||
|
|
||
| public static final ConfigOption<Double> CRT_TARGET_THROUGHPUT_GBPS = | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this soft or hard limit? |
||
| ConfigOptions.key("s3.crt.target-throughput-gbps") | ||
| .doubleType() | ||
| .defaultValue(10.0) | ||
| .withDescription( | ||
| "Target throughput in Gbps for the CRT-based S3 async client. " | ||
| + "Only used when s3.crt.enabled is true. " | ||
| + "Higher values allow more concurrent transfers."); | ||
|
|
||
| private Configuration flinkConfig; | ||
|
|
||
| @Override | ||
|
|
@@ -414,6 +435,9 @@ public FileSystem create(URI fsUri) throws IOException { | |
| .maxRetries(config.get(MAX_RETRIES)) | ||
| .credentialsProviderClasses(config.get(AWS_CREDENTIALS_PROVIDER)) | ||
| .encryptionConfig(encryptionConfig) | ||
| .useCrt(config.get(CRT_ENABLED)) | ||
| .crtTargetThroughputGbps(config.get(CRT_TARGET_THROUGHPUT_GBPS)) | ||
| .crtMinPartSizeInBytes(config.get(PART_UPLOAD_MIN_SIZE)) | ||
| .build(); | ||
|
|
||
| NativeS3BulkCopyHelper bulkCopyHelper = null; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some step-by-step would be good on doc page