Open
Conversation
Collaborator
Contributor
|
nit: could you change the title prefix to [hotfix] as per the process. Otherwise looks good |
Author
|
Sure, I can do that right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes a GitHub Actions conditional expression in
.github/workflows/template.flink-ci.ymlso the comparison against an empty string is evaluated inside the${{ }}expression.https://github.com/apache/flink/actions/runs/22965038052/workflow#L33
Brief change log
!= ''comparison inside the${{ }}expression in.github/workflows/template.flink-ci.ymlVerifying this change
All pull request checks passed when I ran these changes on my fork.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation