-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38845][runtime] Add ArchivedApplicationStore to manage terminated applications #27388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| <td><h5>archived-application-store.cache-size</h5></td> | ||
| <td style="word-wrap: break-word;">52428800</td> | ||
| <td>Long</td> | ||
| <td>The archived application store cache size in bytes which is used to keep completed applications in memory.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to document the motivation for using the archived application store somewhere so it is obvious the value that the user gets from using this and the risks around staleness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: Added comments around the new configuration options in JobManagerOptions to clarify the transition from job store to application store. And a detailed description can also be found here: https://issues.apache.org/jira/browse/FLINK-38845
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/util/ArchivedApplicationStoreUtils.java
Outdated
Show resolved
Hide resolved
...time/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedApplicationStoreTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/application/AbstractApplication.java
Outdated
Show resolved
Hide resolved
zhuzhurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments. @eemario
LGTM.
What is the purpose of the change
This pull request replaces ExecutionGraphInfoStore with ArchivedApplicationStore to manage terminated applications (rather than individual jobs) and handle their expiration.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation