Skip to content

Conversation

@eemario
Copy link
Contributor

@eemario eemario commented Jan 7, 2026

What is the purpose of the change

This pull request replaces ExecutionGraphInfoStore with ArchivedApplicationStore to manage terminated applications (rather than individual jobs) and handle their expiration.

Brief change log

  • Add ArchivedApplicationStore interface and Memory/File implementation
  • Replace ExecutionGraphInfoStore with ArchivedApplicationStore in the Dispatcher to manage terminated applications instead of individual jobs
  • Add configuration options for ArchivedApplicationStore and deprecate options for JobStore

Verifying this change

This change added tests and can be verified as follows:

  • Added tests that validate the behavior of Memory/File ArchivedApplicationStore
  • Added integration tests that validate the behavior of Dispatcher when handling job/application termination
  • Manually verified the change by running a standalone cluster in session mode

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 7, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@eemario eemario marked this pull request as ready for review January 7, 2026 05:31
<td><h5>archived-application-store.cache-size</h5></td>
<td style="word-wrap: break-word;">52428800</td>
<td>Long</td>
<td>The archived application store cache size in bytes which is used to keep completed applications in memory.</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to document the motivation for using the archived application store somewhere so it is obvious the value that the user gets from using this and the risks around staleness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: Added comments around the new configuration options in JobManagerOptions to clarify the transition from job store to application store. And a detailed description can also be found here: https://issues.apache.org/jira/browse/FLINK-38845

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 7, 2026
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments. @eemario
LGTM.

@zhuzhurk zhuzhurk merged commit 8c5735f into apache:master Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants