[FLINK-37002][table] Migrate DecomposeGroupingSetsRule to java #27384
+450
−338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyongvs
force-pushed
the
DecomposeGroupingSetsRule
branch
from
04cb7bd to
3437835
Compare
liuyongvs
changed the title
Collaborator
davidradl
approved these changes
Jan 6, 2026
Contributor
davidradl
left a comment
davidradl
left a comment
There was a problem hiding this comment.
Assuming the test coverage is good, I see the build passes; this looks good to me.
github-actions
bot
added
the
community-reviewed
snuyanzin
reviewed
Jan 10, 2026
| import java.util.stream.IntStream; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import scala.collection.JavaConverters; |
Contributor
There was a problem hiding this comment.
can we avoid this in java?
Contributor
There was a problem hiding this comment.
for instance use JavaScalaConversionUtil instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR migrates DecomposeGroupingSetsRule to java
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation