Skip to content

Conversation

@dylanhz
Copy link
Contributor

@dylanhz dylanhz commented Dec 31, 2025

What is the purpose of the change

Add two ArgumentStrategy to support array with specified element type, providing more flexible and convenient type validation for collection-based functions.

Brief change log

  • Add ArrayOfRootArgumentTypeStrategy and ArrayOfFamilyArgumentTypeStrategy.
  • Add arrayOf() shortcut for strategies above, similar to the existing logical().
  • Replace ArrayOfStringArgumentTypeStrategy with arrayOf(LogicalTypeFamily.CHARACTER_STRING)

Verifying this change

  • InputTypeStrategiesTest
  • CollectionFunctionsITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@dylanhz
Copy link
Contributor Author

dylanhz commented Dec 31, 2025

The pr will be rebased once the first commit is merged.

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 31, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

or(
sequence(
new ArrayOfStringArgumentTypeStrategy(),
arrayOf(LogicalTypeFamily.CHARACTER_STRING),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you update the Jira text with some examples on how this will effect the externals and add to the documentation if appropriate.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants