Skip to content

[FLINK-32695] [Tests] Migrate ProcessingTimeServiceSource from Source Function to Source V2 API in StreamSourceOperatorLatencyMetricsTest #26813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Poorvankbhatia
Copy link
Contributor

What is the purpose of the change

This pull request migrates the ProcessingTimeServiceSource test utility from the deprecated SourceFunction API to the new Source V2 API in StreamSourceOperatorLatencyMetricsTest.

Brief change log

  • Replaced ProcessingTimeServiceSource extends SourceFunction with ProcessingTimeServiceSource implements Source<Long, SourceSplit, Void>
  • Implemented required Source V2 interfaces: SourceReader, SplitEnumerator, and serializers
  • Updated test execution logic to use operator.emitNext() pull-based model instead of the push-based operator.run()
  • Added JavaDoc documentation clarifying the test-only nature of ProcessingTimeServiceSource

Verifying this change

This change is already covered by existing tests, such as:

  • All 5 existing test cases in StreamSourceOperatorLatencyMetricsTest continue to pass:
    • testLatencyMarkEmissionDisabled
    • testLatencyMarkEmissionEnabledViaExecutionConfig
    • testLatencyMarkEmissionEnabledViaFlinkConfig
    • testLatencyMarkEmissionEnabledOverrideViaExecutionConfig
    • testLatencyMarkEmissionDisabledOverrideViaExecutionConfig

The tests verify that latency markers are correctly emitted (or not emitted) based on various configuration settings.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…Function to Source V2 API in StreamSourceOperatorLatencyMetricsTest
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 19, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Poorvankbhatia
Copy link
Contributor Author

@afedulov, please have a look. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants