Skip to content

[FLINK-37820][table-planner] Support AsyncScalarFunction registration via CompiledPlan #26586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

ferenc-csaky
Copy link
Contributor

What is the purpose of the change

Currently, if you try to load a CompiledPlan that contains any UDF that extends AsyncScalarFunction and is not loaded already, the plan will fail to load, cause RexNodeJsonDeserializer does not know about the ASYNC_SCALAR function kind. This should be supported, cause in this regard, SCALAR and ASYNC_SCALAR has no relevant difference.

Brief change log

  • Add ASYNC_SCALAR function kind to RexNodeJsonDeserializer.
  • Provide unit tests to cover the added logic.

Verifying this change

Extended RexNodeJsonSerdeTest unit tests that covers the added logic.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented May 22, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@ferenc-csaky ferenc-csaky merged commit 8e93850 into apache:master May 27, 2025
@ferenc-csaky ferenc-csaky deleted the FLINK-37820 branch May 27, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants