FLINK-37949: Avoid netty deadlock with graceful shutdown #215
+155
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
...rc/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Outdated
Show resolved
Hide resolved
leekeiabstraction
approved these changes
Jun 16, 2025
|
Thank you for the contribution, Jason. Approved! |
hlteoh37
reviewed
Jun 25, 2025
There was a problem hiding this comment.
LGTM @jayteej Thanks for the contribution!
Some housekeeping, if that's ok! 👀
- CI is failing due to formatting errors, do you mind running
mvn spotless:applyto fix them? - The title of the commit is not correct - can we squash into 1 and follow the format of
[FLINK-37949][Connectors/Kinesis] xxxx?
jayteej
force-pushed
the
FLINK-37949
branch
5 times, most recently
from
94b7a8e to
161529a
Compare
Sorry for the delay @jayteej hlteoh37. I didn't notice u responded. I've had to refactor this as the trunk changed the file structure quite a lot. And thanks for the review |
…t Netty deadlocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-37949 shows that a deadlock in the netty client can cause savepoint delay. This change ensures that any pending operations are terminated before closing down the client and also updates the latest minor version of netty in case this is a known deadlock issue.